fix(routing): filter internal Azure routing models from GitHub Copilot#1596
Merged
fix(routing): filter internal Azure routing models from GitHub Copilot#1596
Conversation
…t provider The Copilot API returns internal `accounts/msft/routers/*` entries that are Azure load-balancing infrastructure, not user-facing chat models. Add a PROVIDER_NON_CHAT filter for copilot and apply filterNonChatModels at cache-read time so previously-cached entries are also excluded.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1596 +/- ##
==========================================
+ Coverage 97.92% 98.00% +0.08%
==========================================
Files 118 119 +1
Lines 8675 8936 +261
Branches 3265 3364 +99
==========================================
+ Hits 8495 8758 +263
+ Misses 178 176 -2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api.githubcopilot.com/models) returns internal Azure routing entries (accounts/msft/routers/*) that are infrastructure-level load balancing endpoints, not user-facing chat modelscopilotentry toPROVIDER_NON_CHATregex filter to exclude these at fetch timefilterNonChatModels()at cache-read time ingetModelsForAgent()so previously-cached routing entries are also filtered outTest plan
provider-model-fetcher.service.spec.ts)model-discovery.service.spec.ts)accounts/msft/routers/*models no longer appear in the model selection modalSummary by cubic
Filters internal Azure routing models from GitHub Copilot so only real chat models appear. Filtering runs on fetch and on cache reads to remove
accounts/msft/routers/*entries.copilottoPROVIDER_NON_CHATto exclude router IDs.filterNonChatModels()to cached results ingetModelsForAgent().Written for commit e638138. Summary will update on new commits.